565026 - Tamarin build failures on ARM (-Wcast-align).

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Jacob Bramley [:jbramley]]

I need to build Tamarin in order to test a patch for NanoJIT. This never used to be a problem, but now I keep getting problems with -Wcast-align causing warnings which subsequently clobber the build.

The warnings are common in Trace Monkey but Tamarin had historically been kept clean of them. Now they are appearing in Tamarin, -Werror is making it a problem. We should, however, endeavour to fix the source of the problem in Trace Monkey. If nothing else, it will drastically reduce the build noise.

Options:
  * Remove -Wcast-align from the ARM build. This is probably a bad idea, as it can catch real bugs.
  * Fix each individual instance. This will be time-consuming and difficult to maintain, as new code will need checking (and won't be checked by the easy-to-test x86 builds).

It's also possible that neither of the above options are desirable, and a third option must be considered.

Any thoughts?

Comment 1

[Jacob Bramley [:jbramley]]

I'm escalating the importance; this essentially blocks all NanoJIT development for ARM as we can't submit patches to nanojit-central without first testing on TM and TR, and currently I can't build TR.

Comment 2

[Edwin Smith]

For the time being, it would be fine to remove -Werror from TR manually, for testing purposes.  I beleive the bug is in fact the use of -Werror, since we don't use it unversally and do have a few warnings which cannot be removed on some platforms.

Comment 3

[Jacob Bramley [:jbramley]]

Hmm. Sometimes, perhaps. There are cases when the compiler will emit a warning to indicate incorrect code that it will compile anyway, and -Werror is nice for catching those, but perhaps removing -Werror is the best option. I'll leave that up to you, but will locally hack the build system in the meantime.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.