565048 - move accel+up/down/left/right/home/end keypress handler to the tab container binding

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 444669 [details] [diff] [review]
patch

>diff --git a/browser/base/content/tabbrowser.xml b/browser/base/content/tabbrowser.xml

>+      <handler event="keypress"><![CDATA[
>+        if (event.altKey || event.shiftKey ||
>+#ifdef XP_MACOSX
>+            !event.metaKey)
>+#else
>+            !event.ctrlKey)
>+#endif

Not that it matters much, but you need || event.metaKey in the non-XP_MACOSX case to maintain existing behavior. (It appears to be possible for metaKey to be set on beos/qt and apparently also for gtk, though I'm not sure under exactly what circumstances - gtk docs suggest it is dependent on X server config.)

We should indeed have tests for this, as Shawn pointed out in the other bug.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f0822abe3433

added || event.metaKey as suggested