Closed
Bug 565078
Opened 13 years ago
Closed 13 years ago
Move js/src/ipc to js/ipc.
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
People
(Reporter: mozilla+ben, Assigned: mozilla+ben)
References
Details
Attachments
(1 file, 1 obsolete file)
5.48 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
We do not plan to ship the mozilla::jsipc bits with the standalone JS engine, so that code should probably live in js/ipc instead of js/src/ipc.
Assignee | ||
Comment 1•13 years ago
|
||
Note that this change required updating a few build files, but not changing any consumers of the CPOW code, because the namespace (mozilla::jsipc) remains unchanged.
Attachment #444705 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•13 years ago
|
||
The previous patch was much larger than necessary (twice as large as the original CPOW patch), due to deleting and re-adding every file.
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 444705 [details] [diff] [review] Patch to rename js/src/ipc to js/ipc. Yep, that worked.
Attachment #444705 -
Attachment is obsolete: true
Attachment #444705 -
Flags: review?(benjamin)
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 444760 [details] [diff] [review] Patch to do the renaming. This should be much easier to review.
Attachment #444760 -
Attachment description: Hoping this version of the patch represents the renaming through file moves instead of deletions/additions. → Patch to do the renaming.
Attachment #444760 -
Flags: review?(benjamin)
Updated•13 years ago
|
Attachment #444760 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Pushed to projects/electrolysis: http://hg.mozilla.org/projects/electrolysis/rev/1c7b03e451a0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•