565117 - Don't revert axis locking after scrolling past a certain distance

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

For bug 521108 we added code to revert axis locking after change of direction, to prevent accidental locking from random movement during the initial touch.

The downside is that axis locking can be reverted when not desired - especially when scrolling up a page and then back down, and dragging near the original touch location.  This is a common problem I've observed in Fennec use by myself and others.

With this patch, Fennec will no longer revert its axis locking decision if the user has dragged more than 200 pixels in either direction.  This preserves the intended benefit of bug 521108 but eliminates most accidental reversions.

Comment 1

[Benjamin Stover (:stechz)]

Comment on attachment 444713 [details] [diff] [review]
patch

Feels good on desktop.  Code looks good.

Comment 2

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mobile-browser/rev/af4a1625302e

Comment 3

[Aakash Desai [:aakashd]]

Is this only going onto 2.0? or will it also go onto 1.1?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Only 2.0

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100519 Namoroka/3.7a5pre Fennec/2.0a1pre