565128 - Jetpack is not working properly with latest Firefox nightly

Status: VERIFIED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Filing with a generic title summary because I don't know the reason. We can update it as we get more info. I've checked on Windows and Mac that it works with the 20100510 nightly, and doesn't work with the 20100511 nightly. 

Possibly related to the new add-ons manager? Here are all checkins in range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3a26cbe20cd2&tochange=ce9f07472020

The most noticeable difference is that when you run |cfx test| on jetpack core, the Firefox window (and the "Running tests" window) doesn't appear immediately, although some tests begin to run and the test hangs on an exception.

Other leads:  I can't do Cu.import("resource://my-first-package-jetpack-core-lib/cuddlefish.js") anymore.
Also, on my Page Worker patch, the hiddenWindow seems to be non-existent on the moment the package is require()d.

Comment 1

[Drew Willcoxon :adw]

Atul mentioned yesterday that he accidentally committed some WIP rebootless code as part of another patch that might be causing this here:
http://hg.mozilla.org/labs/jetpack-sdk/rev/c18a103886e3

Sure enough, Paul backed out the commit:
http://hg.mozilla.org/labs/jetpack-sdk/rev/d5582d613650

And relanded the intended changes:
http://hg.mozilla.org/labs/jetpack-sdk/rev/508fd04bcf9c

And now the nightly works again -- except for some errors that were happening before, and some private browsing errors, for which I've filed bug 565338.  So marking fixed, by these changes, but of course please reopen if you can still reproduce.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Indeed, it works for me now. Verified on Windows and OS X.

The only thing I see now using latest trunk builds and run cfx test on jetpack-core is a warning thrown at test-tab-browser.addNewTab, and on Windows something leaks the world.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".