"cfx xpi" shouldn't include editor "*~" tempfiles

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: warner, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 444765 [details] [diff] [review]
add IGNORED_FILE_SUFFIXES to "cfx xpi", containing "~"

There are a handful of files that editors and other tools leave lying around. The SDK should not copy them into generated tarballs, etc. The most obvious is emacs' tilde-suffix for backup files: e.g. when you edit "foo.txt", you get a "foo.txt~" leftover. The "preflight" work I'm going may create "package.json.backup", which should probably be treated the same way, although I'm not going to add that ignoring in this bug.

The attached patch adds an IGNORED_FILE_SUFFIXES list, populated with just "~".
(Reporter)

Updated

8 years ago
Attachment #444765 - Flags: review?(avarma)

Comment 1

8 years ago
This appears to be of MIME type application/octet-stream, which makes it impossible for me to view on bugzilla--could you re-upload it in a viewable form?

Updated

8 years ago
Attachment #444765 - Attachment is patch: true
Attachment #444765 - Attachment mime type: application/octet-stream → text/plain

Comment 2

8 years ago
Comment on attachment 444765 [details] [diff] [review]
add IGNORED_FILE_SUFFIXES to "cfx xpi", containing "~"

Looks great, thanks! (And thanks Josh for changing the MIME type, didn't realize I could do that.)
Attachment #444765 - Flags: review?(avarma) → review+
(Reporter)

Comment 3

8 years ago
landed in a9924484005f
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.