Closed Bug 565188 Opened 13 years ago Closed 13 years ago

simplify sp adjustment in checkTraceEnd

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: luke, Assigned: luke)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
2.48 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
The sp adjustment expression in TraceRecorder::checkTraceEnd is a little more mind-bending than average and not at all future proof.  For example, Andreas's recent fast iterator patch had to add a special case just for JSOP_MOREITER.  However, the adjustment in theory is very simple: set sp to its offset at loop entry.  This patch just takes a snapshot (like we already do with ip).  TreeFragment::nStackTypes almost already has what we want, but it pulls in more than just sp - StackBase(fp).
Attachment #444780 - Flags: review?(dvander)
Attachment #444780 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/353a8a5434ab
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/353a8a5434ab
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.