Closed
Bug 565240
Opened 14 years ago
Closed 14 years ago
colchange.cgi shouldn't send full-page content after its redirect() call
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
|
301 bytes,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
colchange.cgi does a redirect() and *then* prints a template. Currently, under mod_perl, this causes two <body> tags to be sent, which possibly is the underlying cause of bug 376044 when it happens (although we can't reliably reproduce it, so I have no idea).
|
Assignee | |
Comment 1•14 years ago
|
||
Simple patch that prevents rendering the template after the redirect call.
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
Attachment #444823 -
Flags: review?(justdave)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 444823 [details] [diff] [review] v1 yup yup. Technically, you're supposed to send en entity body with a text explanation of the redirect when you do a redirect, in case of browsers that didn't implement 30x statuses correctly. I don't know of any browser still in common usage that can't handle a 30x response these days, and apache does it for us under mod_perl, which is the root of the problem here.
Attachment #444823 -
Flags: review?(justdave) → review+
|
|
Assignee | |
Updated•14 years ago
|
Flags: approval3.6+
Flags: approval+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified colchange.cgi Committed revision 7156 Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified colchange.cgi Committed revision 7094.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•