deadcode in nsOggReader::FindEndTime if !codecState

RESOLVED FIXED

Status

()

--
trivial
RESOLVED FIXED
9 years ago
3 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
793 PRInt64 nsOggReader::FindEndTime(PRInt64 aEndOffset)

892     if (!codecState) {
893       // This page is from a bitstream which we haven't encountered yet.
894       // It's probably from a new "link" in a "chained" ogg. Don't
895       // bother even trying to find a duration...
896       break;

899     PRInt64 t = codecState ? codecState->Time(granulepos) : -1;
(Assignee)

Comment 1

9 years ago
Created attachment 444898 [details] [diff] [review]
proposal
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #444898 - Flags: review?(chris.double)

Comment 2

8 years ago
Comment on attachment 444898 [details] [diff] [review]
proposal

Changed reviewer to cpearce as he is more familiar with the ogg seeking code.
Attachment #444898 - Flags: review?(chris.double) → review?(chris)
Comment on attachment 444898 [details] [diff] [review]
proposal

Thanks! The offending code is left over from when there was more debug logging in there, and should be removed.
Attachment #444898 - Flags: review?(chris) → review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/84599af3f0c8
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Blocks: 1230156
You need to log in before you can comment on or make changes to this bug.