Closed
Bug 565337
Opened 14 years ago
Closed 14 years ago
Please cache GetOpactiy() in ContainerLayerOGL::RenderLayer
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
1.41 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Coverity can't trust GetOpacity() to return a constant value, as it's used three times in this function, it's better to cache it and make coverity happy than call the same function three times (unless it's actually dynamic, in which case coverity says you can use uninitialized data). 128 ContainerLayerOGL::RenderLayer(int aPreviousFrameBuffer) 133 GLuint containerSurface; 140 if (GetOpacity() != 1.0) { 182 } else { 183 frameBuffer = aPreviousFrameBuffer; 184 } 205 if (GetOpacity() != 1.0) { 235 gl()->fBindTexture(LOCAL_GL_TEXTURE_2D, containerSurface); 237 rgbProgram->SetLayerOpacity(GetOpacity());
Updated•14 years ago
|
Attachment #444900 -
Flags: review?(bas.schouten) → review+
Component: Canvas: WebGL → Graphics
QA Contact: canvas.webgl → thebes
http://hg.mozilla.org/mozilla-central/rev/adf43a8697ee
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•