565395 - Use z.anonymous to check for loggedIn status

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P5)

Description

[Jeff Balogh (:jbalogh)]

zamboni/addon_details.js checks for login status with this:

        loggedIn: $(document.body).attr('data-anonymous')

We already have that in z.anonymous, which is set in zamboni/init.js.

I'm fixing other bugs right now, so you're getting a new bug. ;)

Comment 1

[Fred Wenzel [:wenzel]]

That can be arranged.

Comment 2

[Fred Wenzel [:wenzel]]

Hm, apparently this was only used in a stars() call, whose selector did not match anything. All gone:

http://github.com/jbalogh/zamboni/commits/94f71bf

QA: If you can still submit a review with rating from the details page, all is well.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

https://preview.addons.mozilla.org/en-US/firefox/reviews/display/64250
https://preview.addons.mozilla.org/en-US/firefox/addon/64250/ (needs cron to run before rating/review show up)