Use z.anonymous to check for loggedIn status

VERIFIED FIXED in 5.11

Status

addons.mozilla.org Graveyard
Code Quality
P5
trivial
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: jbalogh, Assigned: wenzel)

Tracking

Details

(Whiteboard: [z])

(Reporter)

Description

8 years ago
zamboni/addon_details.js checks for login status with this:

        loggedIn: $(document.body).attr('data-anonymous')

We already have that in z.anonymous, which is set in zamboni/init.js.

I'm fixing other bugs right now, so you're getting a new bug. ;)
(Assignee)

Comment 1

8 years ago
That can be arranged.
Severity: normal → trivial
Priority: -- → P5
(Assignee)

Comment 2

8 years ago
Hm, apparently this was only used in a stars() call, whose selector did not match anything. All gone:

http://github.com/jbalogh/zamboni/commits/94f71bf

QA: If you can still submit a review with rating from the details page, all is well.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Verified FIXED:

https://preview.addons.mozilla.org/en-US/firefox/reviews/display/64250
https://preview.addons.mozilla.org/en-US/firefox/addon/64250/ (needs cron to run before rating/review show up)
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.