565411 - Sync 5000 most frecent pages instead of 1000 recent for first sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Some people aren't experiencing their awesomebar on synced devices.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

Attachment: v1.1

limit to 30 recent days

Comment 3

[Mike Connor [:mconnor]]

We're in heavy risk-mitigation mode here, so punting this to 2.0.  Very very much do want.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 444989 [details] [diff] [review]
v1.1

Please make the limit a param (max_results) as with the cutoff date.  We may want to modify the initial upload for mobile clients, and we might as well give ourselves that flexibility now.

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/a3203e6bedfe
Use an async sql query to get uris by frecency instead of query result nodes, and wrap it with sync/async to keep the sync interface without blocking UI. Rough timings of getAllIDs: old 1k = 1.6sec blocking; old 5k = 2.7sec blocking; new 1k = .2sec non-block; new 5k = .6sec non-block. 

http://hg.mozilla.org/labs/weave/rev/7828087531c2
Accept max_results as a parameter to allow configuring the number of history items.

Comment 6

[Ragavan S [:rags]]

Sweet - this is awesome stuff, we get *more* data and take *less* time! Good work, Mardak!