AutoValueVector OOM misreporting in jsiter.cpp

RESOLVED FIXED in mozilla1.9.3a5

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla1.9.3a5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
!vec.append(...) where vec is AutoValueVector means vec internally uses ContextAllocPolicy, so when a failure happens it's reported.  Reporting an error atop that is wrong.

Comment 1

9 years ago
Can you whip up a quick patch?
(Assignee)

Comment 2

9 years ago
Created attachment 445001 [details] [diff] [review]
Patch

Oh hey, a couple failures to report error as well, wicked!
Attachment #445001 - Flags: review?(jorendorff)
Attachment #445001 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/tracemonkey/rev/abeb114181d5
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.3a5

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/abeb114181d5
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.