565502 - [k] Replace excess try blocks with get_object_or_404

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[James Socol [:jsocol, :james]]

In forums.views there are a number of place we do basically this:

    try:
        obj = Cls.objects.get(x=y)
    except Cls.DoesNotExist:
        return Http404

That is just the long hand form of:

    from django.shortcuts import get_object_or_404

    obj = get_object_or_404(Cls, x=y)

For clarity and suscin...su....being concise, we should use the shortcut.

Comment 1

[Josh Gross (:jgross)]

http://github.com/jsocol/kitsune/commit/d4dadebe6786039a70d0ccec4b5ea1abf1da958c