565508 - Remove the ugly hacks for copying the right thing from about:privatebrowsing once bug 39098 is fixed.

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

Bug 471935 added some hacks to make sure that the correct thing is copied from about:privatebrowsing.  When bug 39098 lands, that hack won't be necessary.  Filing this for now to make sure that I won't forget to do that.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

This is a nearly straight backout of http://hg.mozilla.org/mozilla-central/rev/029630824401, merged to tip.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 447452 [details] [diff] [review]
Patch (v1)

>+      body.normal .showPrivate {
>+        display: none;
>+      }
>+      body.normal .showNormal {
>+        display: block;
>+      }
>+      body.private .showPrivate {
>+        display: block;
>+      }
>+      body.private .showNormal {
>+        display: none;
>+      }

What's the display:block stuff supposed to do? How about the following?

      body.normal .showPrivate,
      body.private .showNormal {
        display: none;
      }

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

Good point!

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b84dd5c2cb18