Closed Bug 565601 Opened 14 years ago Closed 14 years ago

useless comparison in FunctionType::Create

Categories

(Core :: js-ctypes, defect)

defect
Not set
trivial

Tracking

()

RESOLVED INVALID

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

4657 FunctionType::Create(JSContext* cx, uintN argc, jsval* vp)
4658 {
4659   // Construct and return a new FunctionType object.
4660   if (argc < 2 || argc > 3) {
4661     JS_ReportError(cx, "FunctionType takes two or three arguments");
4662     return JS_FALSE;

after this point, argc must be 3

4669   if (argc == 3) {
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #445077 - Flags: review?(dwitte)
argc can be 2 or 3, no?
Attachment #445077 - Flags: review?(dwitte) → review-
sorry. yeah, i misread coverity's report and reached the wrong conclusion.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: