565700 - OS X 64 bit builds do not run make check

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

I'm filing this for philor, but he says we aren't running make check on os x 64 bit builds.  This is sadfaces.

Comment 1

[[e-mail] (:bhearsum)]

Bear, can you have a look at this when you have time? We probably forgot to flip the right config.py bit.

Comment 2

[Mike Taylor [:bear]]

There were a number of bits that didn't get flipped because of the lack of symbols and breakpad support, etc.  

But yes, I have scheduled for early next week a review of outstanding OS X 64bit bugs and this is now on the list :)

thanks

Comment 4

[Mike Taylor [:bear]]

Attachment: enable "make check" for OSX 64

I'll install the patch on staging once bhearsum confirms I have the right config item flipped

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 459945 [details] [diff] [review]
enable "make check" for OSX 64

You need to flip it in mozilla/config.py, too. mozilla2{,-staging} only applies to release builds these days.

You also need to flip it on for debug builds.

Comment 6

[Mike Taylor [:bear]]

Attachment: enable "make check" for OSX 64

enabled in mozilla/config.py and also for -debug

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 460624 [details] [diff] [review]
enable "make check" for OSX 64

please to be testing in staging before this lands

Comment 8

[Mike Taylor [:bear]]

Attachment: enable "make check" for OSX 64

the original patch was against -r buildbot-0.8.0 and I forgot that buildbot-configs is now "unified"

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 460954 [details] [diff] [review]
enable "make check" for OSX 64

Sorry...you missed mozilla2-staging.

Comment 10

[Mike Taylor [:bear]]

Attachment: enable "make check" for OSX 64

mozilla2, mozilla2-staging and mozilla -- all present

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 461036 [details] [diff] [review]
enable "make check" for OSX 64

http://hg.mozilla.org/build/buildbot-configs/rev/5be0b5cd1454