Closed
Bug 565700
Opened 14 years ago
Closed 14 years ago
OS X 64 bit builds do not run make check
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sdwilsh, Assigned: bear)
References
Details
Attachments
(1 file, 3 obsolete files)
4.24 KB,
patch
|
coop
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
I'm filing this for philor, but he says we aren't running make check on os x 64 bit builds. This is sadfaces.
Comment 1•14 years ago
|
||
Bear, can you have a look at this when you have time? We probably forgot to flip the right config.py bit.
Assignee: nobody → bear
Assignee | ||
Comment 2•14 years ago
|
||
There were a number of bits that didn't get flipped because of the lack of symbols and breakpad support, etc. But yes, I have scheduled for early next week a review of outstanding OS X 64bit bugs and this is now on the list :) thanks
Status: NEW → ASSIGNED
Assignee | ||
Updated•14 years ago
|
OS: Windows 7 → Mac OS X
Assignee | ||
Comment 4•14 years ago
|
||
I'll install the patch on staging once bhearsum confirms I have the right config item flipped
Attachment #459945 -
Flags: review?(bhearsum)
Comment 5•14 years ago
|
||
Comment on attachment 459945 [details] [diff] [review] enable "make check" for OSX 64 You need to flip it in mozilla/config.py, too. mozilla2{,-staging} only applies to release builds these days. You also need to flip it on for debug builds.
Attachment #459945 -
Flags: review?(bhearsum) → review-
Assignee | ||
Comment 6•14 years ago
|
||
enabled in mozilla/config.py and also for -debug
Attachment #459945 -
Attachment is obsolete: true
Attachment #460624 -
Flags: review?(bhearsum)
Comment 7•14 years ago
|
||
Comment on attachment 460624 [details] [diff] [review] enable "make check" for OSX 64 please to be testing in staging before this lands
Attachment #460624 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 8•14 years ago
|
||
the original patch was against -r buildbot-0.8.0 and I forgot that buildbot-configs is now "unified"
Attachment #460624 -
Attachment is obsolete: true
Attachment #460954 -
Flags: review?(bhearsum)
Comment 9•14 years ago
|
||
Comment on attachment 460954 [details] [diff] [review] enable "make check" for OSX 64 Sorry...you missed mozilla2-staging.
Attachment #460954 -
Flags: review?(bhearsum) → review-
Assignee | ||
Comment 10•14 years ago
|
||
mozilla2, mozilla2-staging and mozilla -- all present
Attachment #460954 -
Attachment is obsolete: true
Attachment #461036 -
Flags: review?(bhearsum)
Comment 11•14 years ago
|
||
Comment on attachment 461036 [details] [diff] [review] enable "make check" for OSX 64 http://hg.mozilla.org/build/buildbot-configs/rev/5be0b5cd1454
Attachment #461036 -
Flags: review?(bhearsum)
Attachment #461036 -
Flags: review+
Attachment #461036 -
Flags: checked-in+
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•