Closed
Bug 56574
Opened 24 years ago
Closed 24 years ago
Imported IE Favorites in sidebar Bookmarks panel broken!
Categories
(SeaMonkey :: Bookmarks & History, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rgavlin, Assigned: matt)
References
Details
(Keywords: regression, Whiteboard: [rtm++]Fix in hand, reviewed and approved)
Attachments
(3 files)
1.07 KB,
patch
|
Details | Diff | Splinter Review | |
1.12 KB,
patch
|
Details | Diff | Splinter Review | |
8.11 KB,
patch
|
Details | Diff | Splinter Review |
When I double-click on any of my Sidebar->Bookmarks->Imported IE Favorites, I see this in the URL: file:///C|/DOCUMENTS%20AND%20SETTINGS/RONALD%20L.%20GAVLIN/FAVORITES/HTML%20References.url and this in the window: [DEFAULT] BASEURL=http://134.153.41.197/staff/gporter/htmlref.htm [InternetShortcut] URL=http://134.153.41.197/staff/gporter/htmlref.htm Modified=B0BF134780D5BF01DE This is a very recent regression. People who are trying to convert to Mozilla/Netscape 6 will not appreciate this bug very much. I've been seeing it in the MTrunk builds for a few days but today is the first time I saw it in a NS6 build (Build ID: 2000101308). BTW, the Imported IE Favorites work fine from the Bookmarks menu.
Reporter | ||
Updated•24 years ago
|
Keywords: regression,
rtm
Priority: P3 → P1
Comment 1•24 years ago
|
||
I have a fix for this but it involves using OpenBookmarksURL() instead of sidebarOpenURL(), and I assume there's a reason why we're using the latter instead of the former, which the menu uses (I presume it's to fix some of those problems in composer/mailnews with sidebar urls not opening in the correct place...maybe rjc/ben can shed some light here?)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 3•24 years ago
|
||
This is a recent regression (within the last week) that should be fixed before NS6 ships. My Sidebar is one of the NS6 features that might attract IE users. It must import IE bookmarks correctly.
Comment 4•24 years ago
|
||
rjc, can you say why we're using sidebarOpenURL() ?
We are using this because bookmarks where opening in the mail compose window. This code is almost the same as the search sidebar code. looking at this bug right now.
broke with this fix http://bugzilla.mozilla.org/show_bug.cgi?id=48465
I have a fix in hand. Waiting for review. For some reason ds = theRootNode.database; was making the IE bookmarks barf.
Whiteboard: [rtm need info] → [rtm need info] fixing in hand
Comment 10•24 years ago
|
||
r=rjc
Comment 11•24 years ago
|
||
sr=alecf
Whiteboard: [rtm need info] fixing in hand → [rtm+]Fix in hand, reviewed and approved
Comment 12•24 years ago
|
||
OK, we have the fix approved and reviewed.
Reporter | ||
Comment 13•24 years ago
|
||
Using trunk build 2000101804, now none of the "My Sidebar" Bookmarks work. Double-clicking on any Bookmark is now simply ignored.
Comment 14•24 years ago
|
||
PDT says rtm++, please land on branch ASAP, but be careful: if there are any problems with this, we're inclined to back this out, along with the original patch that caused this regression.
Whiteboard: [rtm+]Fix in hand, reviewed and approved → [rtm++]Fix in hand, reviewed and approved
Comment 15•24 years ago
|
||
It looks like you inadvertedly introduced some bustage on the trunk... You're calling clicked with three params while it has two, and you left in a '}' somewhere in openBookmarksURL causing a parsing error, resulting in none of the functions being available, net result: double clicking a bookmark doesn't open it. I'll attach two patches, one whitespace fixed (be damned, you TABs), and one so you can actually see what was wrong ;-)
Comment 16•24 years ago
|
||
Comment 17•24 years ago
|
||
Assignee | ||
Comment 18•24 years ago
|
||
ya when i checked into the trunk i updatedd bm-panel.xul which was not supposed to happen. I had a change in there i didn't want checked in which was really old. The extra } was when it got patched wrong. Got that one fixed. In my branch i never had it. I will fix the white space on the trunk but not on the branch. PDT doesn't like that.
Comment 19•24 years ago
|
||
OK, seems to be working in trunk build 2000102004 on Win2k.
Comment 20•24 years ago
|
||
This is Fixed on Mozilla trunk builds win32 102004 NT 4 mac 102008 Mac OS9
Assignee | ||
Comment 21•24 years ago
|
||
*** Bug 55700 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 22•24 years ago
|
||
Is this going to go into the branch?
Assignee | ||
Comment 23•24 years ago
|
||
fixed in branch tested yesterday in trunk
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 24•24 years ago
|
||
VERIFIED Fixed in 2000102509 branch builds. adding vtrunk keyword
Keywords: vtrunk
Comment 25•24 years ago
|
||
verified fixed with the 2000102604 trunk build on win2k. removing vtrunk keyword.
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•