565767 - XHR doesn't return values from delegated methods

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

For example, XMLHttpRequest.getResponseHeaders() returns a value, but using xhr.XMLHttpRequest.getResponseHeaders() returns undefined (since the original return value isn't also returned.

Comment 1

[Atul Varma [:atul]]

Oops, thanks for the report. Since you've assigned this to yourself, I assume you'd like to fix it?

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

I did forget to attach it... blocked by bug 565767 because the test is depending on assertEqual distinguishing between null and undefined.

I could do
> assert(null !== undefined)
but I'd rather do this "correctly". If it's taking too long to track down everything in bug 565767 then I'll do this the alternate way.

Comment 3

[Atul Varma [:atul]]

Comment on attachment 445410 [details] [diff] [review]
Patch v0.1

Sounds good. This patch looks fine, so feel free to land it once the blocker does.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I'm just going to land this with assert(a === null) since the discussion in bug 565765 is not resolving itself quick enough. If that gets fixed, it'll just have to include changing this assert as well.

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

pushed http://hg.mozilla.org/labs/jetpack-sdk/rev/69fce726158a

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".