565815 - [FIX]Use Element in TransitionManager

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Some simple cleanup to make sure only Elements make their way into the transition manager.  I need this to make it easier to change some code the transition manager later calls.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: With one more null-check

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 445267 [details] [diff] [review]
With one more null-check

Did we conclude on dev-platform that this was the namespace solution that we wanted, or was
  namespace dom = mozilla::dom;
and then dom::Element preferred?

r=dbaron either way, I guess

Comment 4

[Boris Zbarsky [:bzbarsky]]

I think we decided on the latter for "not really DOM" code and that |using namespace mozilla::dom| is ok for code we expect to wrap in |namespace mozilla { namespace dom { } }| at some point.  I could do dom::Element here if you prefer.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this is probably code we'd expect to wrap in namespace css or namespace layout; that said, maybe we should consider the granularity of our namespaces before we spread them all over the tree.

I'd probably slightly prefer dom::Element, but I don't feel strongly about it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> maybe we should consider the granularity of our namespaces

Indeed.  Webkit has a single WebCore namespace for everything under WebCore (dom, css, etc).

> I'd probably slightly prefer dom::Element,

Done.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/5cd6ca469c92