Closed Bug 565815 Opened 10 years ago Closed 10 years ago

[FIX]Use Element in TransitionManager

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

Some simple cleanup to make sure only Elements make their way into the transition manager.  I need this to make it easier to change some code the transition manager later calls.
Blocks: 562700
Attached patch Like so (obsolete) — Splinter Review
Attachment #445263 - Flags: review?(dbaron)
Attachment #445267 - Flags: review?(dbaron)
Attachment #445263 - Attachment is obsolete: true
Attachment #445263 - Flags: review?(dbaron)
Comment on attachment 445267 [details] [diff] [review]
With one more null-check

Did we conclude on dev-platform that this was the namespace solution that we wanted, or was
  namespace dom = mozilla::dom;
and then dom::Element preferred?

r=dbaron either way, I guess
Attachment #445267 - Flags: review?(dbaron) → review+
I think we decided on the latter for "not really DOM" code and that |using namespace mozilla::dom| is ok for code we expect to wrap in |namespace mozilla { namespace dom { } }| at some point.  I could do dom::Element here if you prefer.
I think this is probably code we'd expect to wrap in namespace css or namespace layout; that said, maybe we should consider the granularity of our namespaces before we spread them all over the tree.

I'd probably slightly prefer dom::Element, but I don't feel strongly about it.
> maybe we should consider the granularity of our namespaces

Indeed.  Webkit has a single WebCore namespace for everything under WebCore (dom, css, etc).

> I'd probably slightly prefer dom::Element,

Done.
Pushed http://hg.mozilla.org/mozilla-central/rev/5cd6ca469c92
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.