565968 - tab-switching keyboard shortcuts iterate over all tabs not just the active subset

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

i use keyboard shortcuts to switch between tabs. if i activate a tabcandy group (subset of total tabs) and use keyboard to switch past the left or right end of the group, i get the other tabs, but the tabbar doesn't update.

i think the preferred action is to just operate on the active subset of tabs.

an alternative would be to update the tabbar with the other tabs, but i think that breaks the tab-group interaction.

Comment 1

[Ian Gilman [:iangilman]]

Agreed, on the preferred action.

Comment 2

[Dietrich Ayala (:dietrich)]

bumping priority. not only does this break the tab UI, but it also grievously breaks the grouping illusion. for users who heavily use the keyboard to switch tabs, this makes daily dogfooding very difficult.

Comment 3

[Ian Gilman [:iangilman]]

Aza, Dietrich, any tips on how to control where those keys take us?

Comment 4

[Dietrich Ayala (:dietrich)]

you could listen for the right key events, check for matching combination, and call event.preventDefault() or maybe event.stopPropagation(). i think the former should work and is preferable, iiuc.

once tabcandy lands in core, we can just redefine those.

Comment 5

[Ian Gilman [:iangilman]]

Sounds like a job for Raymond (once he comes on board)

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: Patch

This patch allows users to iterate active tabs using keyboard shortcuts.

@Ian/Aza, please check the patch and apply it to the repos if it's ok.

Comment 7

[Ian Gilman [:iangilman]]

Looks good! Applied in: http://hg.mozilla.org/labs/tabcandy/rev/2e488182142c

Comment 8

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".