566018 - When dragging events that span 8 days, the drag shadow has a wrong length

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

This bug occurs in multiweek/month views and in the all day events header in week view.
It's a regression from patch for bug 476227.

Steps to reproduce:
1. Create a new event that span multiple days with duration 8, 15, 22, ...
   days (if it's an all day event it has to take 7, 14, 21, ... days)
   e.g. from 1/5/2010 to 8/5/2010;
2. drag and drop the event in month view, in multiweek view or in week view if
   the event is an all day one.

Actual results:
the drag shadow take only the first day; for the all day events, the shadow doesn't appear at all.
The final drop position is always correct.

Comment 1

[Decathlon]

Attachment: patch

When I wrote the patch for bug 476227, it seems  I made a mistake when I calculated the length of the event. 
Is there a different way to extract the total days form a duration when they are multiple of 7?

Comment 2

[Markus Adrario [:Taraman]]

Comment on attachment 445436 [details] [diff] [review]
patch

Patch works and looks good.
>Is there a different way to extract the total days form a duration when they
>are multiple of 7?
Looking at [1], there is no way to directly get the number of days.
You could add one, but I think everyone can just multiply weeks by 7 and also reading it in the code should be pretty clear. ;-)

r=markus

[1]:
http://mxr.mozilla.org/comm-central/source/calendar/base/public/calIDuration.idl

Comment 3

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/98cb9480df53

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/e5c10786714c>

a=philipp