566061 - After server syncing, lightweight themes do not get applied to Chrome

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

Attachment: no persona applied screenshot

the server to local data sync (option 2), reports that lightweight themes have been applied from a previous sync.  However, the browser chrome does not update with the applied theme, even though theme manager says it did.

See screenshot
Activity Log: http://pastebin.mozilla.org/724150

Repro:
1) install weave 1.3b5
2) apply a lightweight theme from getpersonas.com 
3) sync everything to the cloud
4) open a new firefox profile, log into your weave account and sync down via option 2 (server data over local data)
5) Verify activity log shows no sync errors, but the chrome browser did not apply the lightweight theme. 

Expected:
- Lightweight theme shoudl be applied to the browser chrome.  Theme manager surely says it did

Actual;
- default theme, not chosen lightweight theme.

Comment 1

[Mike Connor [:mconnor]]

We've had some reports of this, not sure when this regressed.

Also, please don't use pastebin for logs, as it defaults to purging in a day. :(

Comment 2

[Tracy Walker [:tracy]]

Probably not a regression. Seems like a limited case happening at step 4. 

If you're syncing clients that already have accounts setup, theme sync works fine. Bug 561382, which was similar, is still fixed.

Also note that it's just not syncing the chrome of the current window.  With a new window or restart, the theme is applied fine. 

Target 1.4?

Comment 3

[Mike Connor [:mconnor]]

Ed, please kill this one dead.

Comment 4

[Ed Lee :Mardak]

Attachment: v1

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/b4d31fdbeee4
Make sure the pref exists (is a bool) before trying to access its value.