Leading whitespace in install url and learnmore url

VERIFIED FIXED in 5.10.4

Status

addons.mozilla.org Graveyard
API
P1
critical
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: mfinkle, Assigned: davedash)

Tracking

unspecified
5.10.4
x86
Mac OS X

Details

Similar to bug 423135, the <learnmore> content and the <install> content have leading whitespace. Previous versions of the API did not include the whitespace and the change caused bustage in Fennec (see bug 565883)
Hmm, so this affected the current version of the API and is currently causing problems for add-on installation in shipped builds?
Severity: normal → critical
Priority: -- → P1
Target Milestone: --- → 5.11
It is affecting shipped builds of Fennec. The only reported bug is the download progress bar is broken, but the add-on should still be installed. There could be other issues waiting to be reported.
Assignee: nobody → dd
http://github.com/jbalogh/zamboni/commits/41b0d82

Didn't realize whitespace was significant.  There are now tests for these elements in case we forget in the future.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Mark took a look at https://preview.addons.mozilla.org/en-US/mobile/api/addon/1865 and verified this; thanks, Mark!

(I haven't yet figured out a way around the "server uses an invalid certificate" problem when I open the Add-ons Manager in Fennec once I've pointed it to preview, but the above should work, verification-wise.)
Status: RESOLVED → VERIFIED
(In reply to comment #4)
> (I haven't yet figured out a way around the "server uses an invalid
> certificate" problem when I open the Add-ons Manager in Fennec once I've
> pointed it to preview, but the above should work, verification-wise.)

Fix your device's date and time.
Sadly, even though I did comment 5 and re-tested using preview.* for all values in extensions.get* (which fixed comment 4), I still don't see the scrollbar that was the symptom of this bug.

Reopening because I QA'd this wrongly; sorry about that.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
s/scrollbar/progressmeter
Reclosing, if there are other issues with the API file separate bugs, if there's an issue with the progressbar, not sure that we can help w/o specifics.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: 5.11 → 5.10.4
Verified FIXED for the whitespace issue; as that didn't appear to fix the progress meter issue, I think the Mobile team should spin that off; thanks!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.