566078 - Leading whitespace in install url and learnmore url

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P1)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Similar to bug 423135, the <learnmore> content and the <install> content have leading whitespace. Previous versions of the API did not include the whitespace and the change caused bustage in Fennec (see bug 565883)

Comment 1

[Justin Scott [:fligtar]]

Hmm, so this affected the current version of the API and is currently causing problems for add-on installation in shipped builds?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

It is affecting shipped builds of Fennec. The only reported bug is the download progress bar is broken, but the add-on should still be installed. There could be other issues waiting to be reported.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/41b0d82

Didn't realize whitespace was significant.  There are now tests for these elements in case we forget in the future.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Mark took a look at https://preview.addons.mozilla.org/en-US/mobile/api/addon/1865 and verified this; thanks, Mark!

(I haven't yet figured out a way around the "server uses an invalid certificate" problem when I open the Add-ons Manager in Fennec once I've pointed it to preview, but the above should work, verification-wise.)

Comment 5

[Justin Scott [:fligtar]]

(In reply to comment #4)
> (I haven't yet figured out a way around the "server uses an invalid
> certificate" problem when I open the Add-ons Manager in Fennec once I've
> pointed it to preview, but the above should work, verification-wise.)

Fix your device's date and time.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Sadly, even though I did comment 5 and re-tested using preview.* for all values in extensions.get* (which fixed comment 4), I still don't see the scrollbar that was the symptom of this bug.

Reopening because I QA'd this wrongly; sorry about that.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

s/scrollbar/progressmeter

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Reclosing, if there are other issues with the API file separate bugs, if there's an issue with the progressbar, not sure that we can help w/o specifics.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for the whitespace issue; as that didn't appear to fix the progress meter issue, I think the Mobile team should spin that off; thanks!