Last Comment Bug 566139 - Use Suite's search tips rather than toolkit's in suitehelp.rdf
: Use Suite's search tips rather than toolkit's in suitehelp.rdf
Status: RESOLVED FIXED
: fixed-seamonkey2.0.6
Product: SeaMonkey
Classification: Client Software
Component: Help Documentation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-15 09:34 PDT by Ian Neal
Modified: 2010-05-16 05:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.13 KB, patch)
2010-05-15 10:10 PDT, Jens Hatlak (:InvisibleSmiley)
iann_bugzilla: review+
Details | Diff | Splinter Review
patch v1a, r=IanN [Checkin: comments 5+6] (1.10 KB, patch)
2010-05-16 05:09 PDT, Jens Hatlak (:InvisibleSmiley)
jh: review+
kairo: approval‑seamonkey2.0.6+
Details | Diff | Splinter Review

Description Ian Neal 2010-05-15 09:34:39 PDT
The only part of toolkit's welcome.xhtml that we use is the search tips part and we have own one, so we should point to that in suitehelp.rdf instead.
Comment 1 Jens Hatlak (:InvisibleSmiley) 2010-05-15 09:53:03 PDT
That would be
  chrome://communicator/locale/help/help_help.xhtml#search_tips
instead of
  chrome://help/locale/welcome.xhtml#search_tips
in suitehelp.rdf#34 then, right?
Comment 2 Jens Hatlak (:InvisibleSmiley) 2010-05-15 10:10:35 PDT
Created attachment 445555 [details] [diff] [review]
patch

If anyone wonders: The linked page is what you get when your search returns no actual results and you click the "[No matching items found.]" placeholder entry.
Comment 3 Ian Neal 2010-05-15 13:21:00 PDT
Comment on attachment 445555 [details] [diff] [review]
patch

>-                        nc:emptysearchlink="chrome://help/locale/welcome.xhtml#search_tips"/>
>+                        nc:emptysearchlink="chrome://communicator/locale/help/help_help.xhtml#search_tips"/>

As the base is set to chrome://communicator/locale/help you only need:
nc:emptysearchlink="help_help.xhtml#search_tips"/>

r=me with that change
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-05-16 05:09:34 PDT
Created attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]
Comment 5 Jens Hatlak (:InvisibleSmiley) 2010-05-16 05:15:58 PDT
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/comm-central/rev/a8916bfae4b2
Comment 6 Jens Hatlak (:InvisibleSmiley) 2010-05-16 05:56:33 PDT
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4f1b71aab48f

Note You need to log in before you can comment on or make changes to this bug.