Use Suite's search tips rather than toolkit's in suitehelp.rdf

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
Help Documentation
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: InvisibleSmiley)

Tracking

({fixed-seamonkey2.0.6})

Trunk
seamonkey2.1a2
fixed-seamonkey2.0.6

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
The only part of toolkit's welcome.xhtml that we use is the search tips part and we have own one, so we should point to that in suitehelp.rdf instead.
(Assignee)

Comment 1

7 years ago
That would be
  chrome://communicator/locale/help/help_help.xhtml#search_tips
instead of
  chrome://help/locale/welcome.xhtml#search_tips
in suitehelp.rdf#34 then, right?
(Assignee)

Comment 2

7 years ago
Created attachment 445555 [details] [diff] [review]
patch

If anyone wonders: The linked page is what you get when your search returns no actual results and you click the "[No matching items found.]" placeholder entry.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #445555 - Flags: review?(iann_bugzilla)
(Reporter)

Comment 3

7 years ago
Comment on attachment 445555 [details] [diff] [review]
patch

>-                        nc:emptysearchlink="chrome://help/locale/welcome.xhtml#search_tips"/>
>+                        nc:emptysearchlink="chrome://communicator/locale/help/help_help.xhtml#search_tips"/>

As the base is set to chrome://communicator/locale/help you only need:
nc:emptysearchlink="help_help.xhtml#search_tips"/>

r=me with that change
Attachment #445555 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]
Attachment #445555 - Attachment is obsolete: true
Attachment #445590 - Flags: review+
(Assignee)

Comment 5

7 years ago
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/comm-central/rev/a8916bfae4b2
Attachment #445590 - Attachment description: patch v1a, r=IanN → patch v1a, r=IanN [Checkin: comment 5]
Attachment #445590 - Flags: approval-seamonkey2.0.6?
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2

Updated

7 years ago
Attachment #445590 - Flags: approval-seamonkey2.0.6? → approval-seamonkey2.0.6+
(Assignee)

Comment 6

7 years ago
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4f1b71aab48f
Attachment #445590 - Attachment description: patch v1a, r=IanN [Checkin: comment 5] → patch v1a, r=IanN [Checkin: comments 5+6]
(Assignee)

Updated

7 years ago
Keywords: fixed-seamonkey2.0.6
You need to log in before you can comment on or make changes to this bug.