Closed Bug 566139 Opened 10 years ago Closed 10 years ago

Use Suite's search tips rather than toolkit's in suitehelp.rdf

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a2

People

(Reporter: iann_bugzilla, Assigned: InvisibleSmiley)

Details

(Keywords: fixed-seamonkey2.0.6)

Attachments

(1 file, 1 obsolete file)

The only part of toolkit's welcome.xhtml that we use is the search tips part and we have own one, so we should point to that in suitehelp.rdf instead.
That would be
  chrome://communicator/locale/help/help_help.xhtml#search_tips
instead of
  chrome://help/locale/welcome.xhtml#search_tips
in suitehelp.rdf#34 then, right?
Attached patch patch (obsolete) — Splinter Review
If anyone wonders: The linked page is what you get when your search returns no actual results and you click the "[No matching items found.]" placeholder entry.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #445555 - Flags: review?(iann_bugzilla)
Comment on attachment 445555 [details] [diff] [review]
patch

>-                        nc:emptysearchlink="chrome://help/locale/welcome.xhtml#search_tips"/>
>+                        nc:emptysearchlink="chrome://communicator/locale/help/help_help.xhtml#search_tips"/>

As the base is set to chrome://communicator/locale/help you only need:
nc:emptysearchlink="help_help.xhtml#search_tips"/>

r=me with that change
Attachment #445555 - Flags: review?(iann_bugzilla) → review+
Attachment #445555 - Attachment is obsolete: true
Attachment #445590 - Flags: review+
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/comm-central/rev/a8916bfae4b2
Attachment #445590 - Attachment description: patch v1a, r=IanN → patch v1a, r=IanN [Checkin: comment 5]
Attachment #445590 - Flags: approval-seamonkey2.0.6?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
Attachment #445590 - Flags: approval-seamonkey2.0.6? → approval-seamonkey2.0.6+
Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4f1b71aab48f
Attachment #445590 - Attachment description: patch v1a, r=IanN [Checkin: comment 5] → patch v1a, r=IanN [Checkin: comments 5+6]
You need to log in before you can comment on or make changes to this bug.