566139 - Use Suite's search tips rather than toolkit's in suitehelp.rdf

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ian Neal]

The only part of toolkit's welcome.xhtml that we use is the search tips part and we have own one, so we should point to that in suitehelp.rdf instead.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

That would be
  chrome://communicator/locale/help/help_help.xhtml#search_tips
instead of
  chrome://help/locale/welcome.xhtml#search_tips
in suitehelp.rdf#34 then, right?

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

If anyone wonders: The linked page is what you get when your search returns no actual results and you click the "[No matching items found.]" placeholder entry.

Comment 3

[Ian Neal]

Comment on attachment 445555 [details] [diff] [review]
patch

>-                        nc:emptysearchlink="chrome://help/locale/welcome.xhtml#search_tips"/>
>+                        nc:emptysearchlink="chrome://communicator/locale/help/help_help.xhtml#search_tips"/>

As the base is set to chrome://communicator/locale/help you only need:
nc:emptysearchlink="help_help.xhtml#search_tips"/>

r=me with that change

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v1a, r=IanN [Checkin: comments 5+6]

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/comm-central/rev/a8916bfae4b2

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 445590 [details] [diff] [review]
patch v1a, r=IanN [Checkin: comments 5+6]

http://hg.mozilla.org/releases/comm-1.9.1/rev/4f1b71aab48f