566148 - Tabs in "Page Info" missing if CountLogins() returns NS_ERROR_FAILURE/calls NS_ERROR()

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Martin Blumenstingl]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100402 Namoroka/3.6.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100402 Namoroka/3.6.3

After installing version 0.6 of the KWallet plugin (this will make firefox store all passwords in the KDE Wallet) the "Page Info" dialog is broken.
It was working with the 0.4 version of the plugin.

See the "actual results" section for a list of issues.

At first I thought this was a bug in the plugin itself.
After some debugging I found out that it's due to two lines of code that were added in version 0.5 of the plugin.
Those two lines of code are basically the following:
    NS_ERROR("CountLogins must set aActionURL or aHttpRealm");
    return NS_ERROR_FAILURE;

replacing these by the following fixes the issue:
    return NS_OK;

Reproducible: Always

Steps to Reproduce:
1. install version 0.6 of the Firefox KWallet plugin (https://addons.mozilla.org/downloads/file/84559/kde_wallet_password_integration-0.6-fx-linux.xpi?src=addondetail)
2. restart firefox
3. right-click on any website, choose "Page Info"
Actual Results:  
1. The "Media" tab in the "Page Info" dialog is missing
2. The "RSS" tab in the Page Info dialog is missing (if the website provides a RSS feed)
3. The "Permissions" tab is broken (the "Use Default" checkbox is unchecked everywhere; also changing the settings there is broken: after you close and reopen the dialog all of your changes have been reverted)

Screenshot: http://img9.abload.de/img/kwalletrs62.png

Expected Results:  
The Page Info dialog should still work (no tabs should be missing)

the CountLogins() method of the KWallet plugin does basically the following:
{
    if (aActionURL.IsVoid() || aHttpRealm.IsVoid())
    {
        /* do stuff... */
        return NS_OK;
    }

    NS_ERROR("CountLogins must set aActionURL or aHttpRealm");
    return NS_ERROR_FAILURE;
}

as soon as NS_ERROR_FAILURE is returned the Page Info dialog will not work anymore.
here's the source code of the plugin: http://www.guillermomolina.com.ar/svn/firefox-kde-wallet/src/KDEWallet.cpp

Comment 1

[Tanner M. Young [:tmyoung]]

Attachment: Screenshot

Comment 2

[Andy McKay]

Legacy extensions are no longer valid in Firefox 57, closing.