566169 - Pasting certain URLs into the location bar creates ignored runloop exceptions, which can break autocomplete

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've seen these "ignored exceptions" before (e.g., bug 548476 comment 3), but tonight I actually hit 1) a reproducible case and 2) at least in my daily-use build, it killed autocomplete.

STR:

1) Paste file:///var/folders/1H/1HobDALdF4ywYA9pUrIKP++++TI/-Tmp-/namebench_2010-05-15_2203.html into the location bar

AR: Console logs

Camino[21121]: *** NSRunLoop ignoring exception 'Can't do regex matching, reason: (Can't open pattern U_REGEX_RULE_SYNTAX (string http://tinderbox.mozilla.org/showbuilds.cgi?tree=Camino, pattern .*file:///var/folders/1H/1HobDALdF4ywYA9pUrIKP++++TI/-Tmp-/namebench_2010-05-15_2203.html.*, case 1, canon 2))' that raised during posting of delayed perform with target 0x24d97e80 and selector 'processNextSearchChunk'

and autocomplete no longer functions.

ER: No ignored exception, autocomplete continues to work.

Note that "string" there is the last URL loaded before pasting.

I haven't yet been able to reproduce killing autocomplete (just the exception), but exceptions are bad ;)

Comment 1

[Stuart Morgan]

This falls into the category of "things I should have caught in review". I think I even suggested some of the regex syntax :( It'll be an easy fix unless the regex syntax isn't what it sounds like it is.

Comment 2

[Stuart Morgan]

Attachment: Escape search strings for regex use

Sadly, NSPredicate doesn't appear to honor \Q \E as it should, so I had to do it manually. This is the list of special characters from the ICU docs, so it should be complete.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 445622 [details] [diff] [review]
Escape search strings for regex use

+  for (unsigned int i = 0; i < [specialCharacters count]; ++i) {
+    NSString* specialCharacter = [specialCharacters objectAtIndex:i];

can you use fast enumeration here?

sr=pink

Comment 5

[Stuart Morgan]

(In reply to comment #4)
> can you use fast enumeration here?

Just as soon as we drop 10.4 support (so, Gecko 1.9.3), yes ;)

Comment 6

[Stuart Morgan]

Landed: 3101:131c1bd3e42b

Comment 7

[Stuart Morgan]

Landed on CVS trunk.