Closed
Bug 56623
Opened 24 years ago
Closed 23 years ago
Possible typo in gfx/src/nsGraphicsImpl.cpp since rev 1.1
Categories
(Core Graveyard :: GFX, defect, P3)
Core Graveyard
GFX
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: h.b.furuseth, Assigned: kmcclusk)
Details
Attachments
(3 files)
664 bytes,
patch
|
Details | Diff | Splinter Review | |
658 bytes,
patch
|
Details | Diff | Splinter Review | |
680 bytes,
patch
|
Details | Diff | Splinter Review |
Gcc warns about the line size *= mDev2App; which actually does size *= (nscoord) mDev2App; // cast floating to integer but looks like (and is maybe meant to do) size = (nscoord) (size * mDev2App); because size is integral and mDev2App floating. Anyway, to kill the warning, spell it out as one of these.
->Compositor
Assignee: asa → kmcclusk
Status: UNCONFIRMED → NEW
Component: Browser-General → Compositor
Ever confirmed: true
QA Contact: doronr → petersen
Reporter | ||
Comment 2•24 years ago
|
||
Sorry, I should've know better than to submit a report just before I rushed out the door... What happens is exactly the opposite of what I said. Don't know how I managed to twist the output to show the opposite. Oh well, at least the proposed change does kill off a warning.
Severity: minor → trivial
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•24 years ago
|
||
Setting milestone to mozilla1.0.1 Reassigning to Waqar.
Assignee: kmcclusk → waqar
Status: ASSIGNED → NEW
Target Milestone: --- → mozilla1.0.1
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Taking this bug
Assignee: waqar → kmcclusk
Target Milestone: mozilla1.0.1 → mozilla0.9.1
Comment 6•23 years ago
|
||
NS_STATIC_CAST instead of direct c-style caset maybe? sr=attinasi
Assignee | ||
Comment 7•23 years ago
|
||
Comment 8•23 years ago
|
||
looks good. r=dcone
Reporter | ||
Comment 9•23 years ago
|
||
Last patch, unlike the first one, changes <size>'s new value from (nscoord) (size * mDev2App) to size * (nscoord) mDev2App I hope that was intentional. This bug has had me wishing for a cancel button for silly Bugzilla reports:-(
Assignee | ||
Comment 10•23 years ago
|
||
Assignee | ||
Comment 11•23 years ago
|
||
Fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•