Improve automation scripts and rewrite most of the MozmillWrapper class

RESOLVED FIXED

Status

Mozilla QA Graveyard
Mozmill Automation
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs-mozmill-1.5.2], URL)

Attachments

(1 attachment)

Once all the refactoring work has happened on bug 565733 we will have to remove the MozmillWrapperCLI class which is a temporarily workaround for my Firefox automation scripts.
Well, bug 564537 should cover the refactoring work now.
Depends on: 564537
No longer depends on: 565733
Component: Mozmill → Mozmill Tests
QA Contact: mozmill → mozmilltests
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Tests
Product: Testing → Mozilla QA
Version: Trunk → unspecified
With Mozmill 1.5.2 we should be able to remove the wrapper now. In the same step we have to rewrite all the scripts.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Depends on: 629107
Summary: Remove MozmillWrapperCLI class from automation scripts → Rewrite automation scripts and remove MozmillWrapperCLI class
Whiteboard: [needs-mozmill-1.5.2]
Assignee: hskupin → nobody
Component: Mozmill Tests → Mozmill Automation
QA Contact: mozmill-tests → mozmill-automation
Assignee: nobody → hskupin
Blocks: 626712
Blocks: 568726
Blocks: 637277
As it looks like right now we can't get rid of the wrapper class by using Mozmill 1.5.2. So I will refactor a lot of our existing code to make it better usable and to integrate some new features.
Summary: Rewrite automation scripts and remove MozmillWrapperCLI class → Improve automation scripts and rewrite most of the MozmillWrapper class
Created attachment 519987 [details] [diff] [review]
Clean-up wrapper class v1 [checked-in]

This patch mostly cleans up the wrapper class to align it better with Mozmill 1.5.2. It removes some unnecessary properties which can be directly set.

I don't want to move large portions of code around right now, but I will check in one of the next patches how to better align the wrapper to the API capabilities Mozmill 1.5.2 offers. Keep in mind the current implementation is from the very beginning.
Attachment #519987 - Flags: review?(jhammel)

Comment 6

7 years ago
Note that bug 607111 is the "last" remaining change necessary to make inhereting from the CLI classes unnecessary (and, strictly speaking, nonsensical if you're using the e.g. MozMill class as an API).  This will be done for 2.0 and I'll get on it as soon as I clean up a few other bugs.

Comment 7

7 years ago
Comment on attachment 519987 [details] [diff] [review]
Clean-up wrapper class v1 [checked-in]

This looks fine.  Wrapper mozmill will become much different -- and easier -- in 2.0, so probably anything done at the wrapper level shouldn't be a deep refactor for 1.5.2 since that will need to be done anyway for 2.0
Attachment #519987 - Flags: review?(jhammel) → review+
Comment on attachment 519987 [details] [diff] [review]
Clean-up wrapper class v1 [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/e4f3af55bf9a
Attachment #519987 - Attachment description: Clean-up wrapper class v1 → Clean-up wrapper class v1 [checked-in]
No longer blocks: 626712
All remaining work now happens on bug 732134 and its dependencies.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.