56634 - regxpcom linked to GTK

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Ben Bucksch (:BenB)]

Part of bug 42184.

<quote src="http://bugzilla.mozilla.org/show_bug.cgi?id=42184">
Regxpcom is currently linked to the GTK
and X11 libs. This appears to be unnecessary and is probably just a
build bug.
</quote>

Comment 1

[cls]

Ummm, it's not linked to X11 nor gtk here.  They don't even show up on the link
line in the build.  Could you attach the regchrome section of your build log?

Comment 2

[cls]

Nevermind. I'm a dork.  I was looking at regchrome, not regxpcom.  Removing
TK_LIBS from the link line removes the gtk/X11 dependency.

Comment 3

[Ben Bucksch (:BenB)]

tenthumbs?

Comment 4

[cls]

Attachment: Remove TK_LIBS from libs...may I say that this is a waste of an attachment

Comment 5

[Ryan Cassin]

Looks good to me, r=[e-mail]

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

sr=shaver

(A waste indeed!)

Comment 7

[tenthumbs]

It will be a while before I build my own Mozilla so I can't say for sure but it
looks right. It should also fix regExport.

This is the third time I've had a mid-air collision on this bug. I hate bugzilla!

Comment 8

[cls]

Patch has been checked in.

Comment 9

[Ben Bucksch (:BenB)]

bugzilla hick-up: Resolution field is empty. Changing to FIXED.

Comment 10

[Ben Bucksch (:BenB)]

.

Comment 11

[Jon Granrose]

verified.