If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

">>>> Writing to clipboard" must be stopped!

RESOLVED FIXED in mozilla0.9

Status

()

Core
XUL
P3
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: shaver, Assigned: Mike Pinkerton (not reading bugmail))

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I'm about to attach a patch.  Need r= and sr=.
Created attachment 17116 [details] [diff] [review]
sweet, blessed silence
Created attachment 17119 [details] [diff] [review]
um, sweet, blessed silence that compiles

Comment 3

17 years ago
Hey!  Please get my name out of those DEBUG_ statements!  I want to see these go
away too, and I had nothing to do with putting them there.  Pavlov might
conceivably want them.

Comment 4

17 years ago
Re review: I'd nitpick that in two cases there's no need for the else clause to
be there at all, and it would be better to put the ifdefs around the whole else
clause rather than inserting braces and ifdefing the contents of the braces. 
But that is a nit, and any reasonable compiler will make them equivalent.

Other than that, r=akkana if you remove my name from the DEBUG_clipboard
definition.
I thought you commented on IRC to the effect that you found them useful.  I
didn't mean to malign you!

I'll take your name out, but I don't like #ifdef around complete else clauses,
so I resist that change.  Unless someone insists, I'll not bother to repost the
patch sans-akkana.

Comment 6

17 years ago
No, don't repost it.  Yes, I found it occasionally helpful, but not so much that
I want to see it every single time the clipboard contents change ... I'll flip
it on locally if I want to debug clipboard stuff. :-)   As for the ifdef around
else, it's your choice, and I certainly don't insist on that for the r=akk.

Sure would be nice if we could turn this off for rtm!  Sigh.
(Assignee)

Comment 7

17 years ago
personally, i think this is good since it has already caught all sorts of
problems on linux with overzealous hitting of the clipboard, but i agree it
should not be a naked printf.

I'd like to see it #ifdef DEBUG, but i'll settle for DEBUG_clipboard if it's
what the masses insist upon.
Target Milestone: --- → mozilla0.9
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 8

17 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.