566377 - Non-ascii characters give us corrupt sessions and break logging in

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P1)

Description

[Wil Clouser [:clouserw]]

We get a lot of corrupt sessions these days and I finally have a test case.  To reproduce:

1) Change your last name to "Kemppilä"
2) Try to log into remora, forwarding to the zamboni home page

If you dump the session, you'll see:
..... s:8:"lastname";s:9:"Kemppil\xe4"; .....

(I can give you the whole line if you like, but I'm not pasting it here for privacy)

I think "Kemppil\xe4" is not coming through as 9 characters and that is what's throwing the deserializing off.

Comment 1

[Jeff Balogh (:jbalogh)]

Hooray unicode!

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Yeah, guess I'll have to patch php.deserializer.

F

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/8b78a42

Dear Quality Assurance Team,

Change your profile data to include lots of garbage unicode characters.  Log out and clear your cookies from remora.  Log back into remora... and see if you can play around on the site.

Asking for Trouble,

Dave

Comment 6

[krupa raj[:krupa]]

We have tested using steps in comment #3 with Hebrew/French/Spanish/Japanese
characters in our Profile page as well as with the example provided in comment
#0)

We have not seen any strangeness so far.

Dave,thanks for the note.