566414 - Signed/unsigned comparison warnings in editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Josh Matthews [:jdm]]

Attachment: Patch

/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4044: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4045: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4045: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4068: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4068: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/txtsvc/src/nsTextServicesDocument.cpp:4070: warning: comparison between signed and unsigned integer expressions

/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp: In member function ‘nsresult nsWSRunObject::GetWSNodes()’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:736: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:804: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:863: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:866: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:869: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:935: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:938: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp: In member function ‘nsresult nsWSRunObject::DeleteChars(nsIDOMNode*, PRInt32, nsIDOMNode*, PRInt32, nsWSRunObject::AreaRestriction)’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:1590: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp: In member function ‘nsresult nsWSRunObject::GetCharAfter(nsWSRunObject::WSPoint&, nsWSRunObject::WSPoint*)’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:1698: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp: In member function ‘PRUnichar nsWSRunObject::GetCharAt(nsIContent*, PRInt32)’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/html/nsWSRunObject.cpp:1944: warning: comparison between signed and unsigned integer expressions

/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/text/nsTextEditRules.cpp:897: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/text/nsTextEditRules.cpp: In member function ‘nsresult nsTextEditRules::WillDeleteSelection(nsISelection*, short int, PRBool*, PRBool*)’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/text/nsTextEditRules.cpp:1031: warning: comparison between signed and unsigned integer expressions
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/text/nsTextEditRules.cpp: In member function ‘virtual nsresult nsTextEditRules::Notify(nsITimer*)’:
/home/t_mattjo/src/firefox/mobilebase/editor/libeditor/text/nsTextEditRules.cpp:1450: warning: comparison between signed and unsigned integer expressions

Comment 1

[(no longer active)]

Comment on attachment 445773 [details] [diff] [review]
Patch

>     PRUint32 len = textNode->TextLength();
>-    if (mOffset<len)
>+    if (PRUint16(mOffset)<len)

Why PRUint16?

Comment 2

[Josh Matthews [:jdm]]

Because mOffset is a PRInt16.

Comment 3

[(no longer active)]

Comment on attachment 445773 [details] [diff] [review]
Patch

Ah, you're right.  I took this for nsWSRunObject::mOffset by mistake.  r=me.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4ec9565fd532

Thanks for the patch, Josh!