Closed Bug 566467 Opened 11 years ago Closed 11 years ago

add memory reporter for win32 memory


(Core :: XPCOM, defect)

Not set





(Reporter: vlad, Assigned: vlad)



(2 files)

We can get Working Set, and on XPSP2+, Private Bytes -- the PB number is actually a useful one, but WS is what users will see in the XP task manager by default.  (Later will see PB.)

This simple patch just adds the query functions to our standard reporters.
Attachment #445828 - Flags: review?(bzbarsky)
I don't think I can competently review this without doing a bunch of winapi reading first... might be better to pick on robarnold or someone like that?
Comment on attachment 445828 [details] [diff] [review]
add win32 mem reporters

Ah right, good call; a win32 reviewer is probably best for this.  Trying Jim Mathies, not sure how busy rob is.
Attachment #445828 - Flags: review?(bzbarsky) → review?(jmathies)
Comment on attachment 445828 [details] [diff] [review]
add win32 mem reporters

win32 calls look ok to me. 

> "",

spelling nit maybe or  truncated on purpose?
Attachment #445828 - Flags: review?(jmathies) → review+
Checked in with typo fix, thanks!
Closed: 11 years ago
Resolution: --- → FIXED
I checked in a bustage fix for non-libxul builds which was making sure we linked against the psapi.lib for xpcom_core.dll:
This bug broke compilation for me. From further investigation, it's because psapi is not linked when --disable-ipc and libxul option is used, but it's now required for core XPCOM now. The attached patch fixes the problem.
Attachment #446702 - Flags: review?(jmathies)
Comment on attachment 446702 [details] [diff] [review]
Fixed compilation with --disable-ipc.

-> ted for build system related approvals
Attachment #446702 - Flags: review?(jmathies) → review?(ted.mielczarek)
Attachment #446702 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
Whiteboard: checkin: comment 6
Assignee: nobody → vladimir
(In reply to comment #6)
> Created an attachment (id=446702) [details]
> Fixed compilation with --disable-ipc.

Pushed as:
Keywords: checkin-needed
Whiteboard: checkin: comment 6
You need to log in before you can comment on or make changes to this bug.