566505 - Review test for log in

Status: RESOLVED FIXED

(Testing Graveyard :: WebQA, defect)

Description

[krupa raj[:krupa]]

Attachment: verify User Login

This is a simple test case which checks user log in.It uses the general login function from AMOfunctions

Comment 1

[krupa raj[:krupa]]

Attachment: AMOfunctions

You need AMOfunctions to run the testcase

Comment 2

[Vishal Kamdar [:vish_moz]]

ret = amo_fcns.login('userNonAdm',sel)
        if ret  == amo_fcns.functionPass:
             print "Log in was successful"
        else:
             print "Login failed"

change else to
else:
    unittest.TestCase.fail('some msg')

Comment 3

[krupa raj[:krupa]]

Attachment: Updated testcase

I have made the changes you suggested.thanks

Comment 4

[Vishal Kamdar [:vish_moz]]

change this line:
                ret = amo_fcns.login('userNonAdm',sel)
to:
                ret = amo_fcns.login(self.tc_params.userNonAdm,sel)
if you want to run the script for just 1 user type.


If you want to run for diff usertypes the you should use a loop like:
 for userType in self.tc_params.userTypeList: 
      ret = amo_fcns.login(userType,sel)

If you don't want to make it too complicated and not use object oriented stuff then just use:
             ret = amo_fcns.login(1,sel)   
             (for non-admin user)

Comment 5

[krupa raj[:krupa]]

Attachment: Login testcase05/20

(In reply to comment #4)
> change this line:
>                 ret = amo_fcns.login('userNonAdm',sel)
> to:
>                 ret = amo_fcns.login(self.tc_params.userNonAdm,sel)
> if you want to run the script for just 1 user type.
> 
> 
> If you want to run for diff usertypes the you should use a loop like:
>  for userType in self.tc_params.userTypeList: 
>       ret = amo_fcns.login(userType,sel)
> 
> If you don't want to make it too complicated and not use object oriented stuff
> then just use:
>              ret = amo_fcns.login(1,sel)   
>              (for non-admin user)
 
As per my discussion with Truman(and you),implementing the method suggested above will break stuff.So retaining the existing code.but I have added a few comments and improved the general formatting.Please review.

Comment 6

[Vishal Kamdar [:vish_moz]]

change this line:
     if ret  == amo_fcns.functionPass:
to
     if ret  == AMOfunctions.AMOfunctions.functionPass:

Since functionPass is a class variable, not an instance variable you can access it using the class name instead of the instance name.

everything else looks good.