Status

Testing
WebQA
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: krupa, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

8 years ago
Created attachment 445859 [details]
verify User logout

Simple testcase to check Log out functionality.Uses AMOfunctions
Attachment #445859 - Flags: review?(vish.mozilla)
Attachment #445859 - Flags: review?(trumanwsmith)
Attachment #445859 - Flags: review?(stephen.donner)
Attachment #445859 - Flags: review?(mozbugs.retornam)
(Reporter)

Comment 1

8 years ago
Created attachment 445860 [details]
AMOfunctions
Attachment #445859 - Attachment mime type: text/html → text/x-python-script
the top most 'if' statement needs an else too.
if ret  == amo_fcns.functionPass:
    'some code'
else:
    unittest.fail('some msg')
(Reporter)

Comment 3

8 years ago
Created attachment 446041 [details]
Updated testcase

I made the changes you suggested.Thanks
Attachment #446041 - Flags: review?(vish.mozilla)
Attachment #446041 - Attachment mime type: text/html → text/x-python-script
My suggested code was pseudo-code (sorry for not making that clear).
The real code should look like
else:
    unittest.TestCase.fail('some msg')
(Reporter)

Comment 5

8 years ago
Created attachment 446083 [details]
Third time is the charm...
(Reporter)

Updated

8 years ago
Attachment #446083 - Flags: review?(vish.mozilla)
Attachment #445859 - Attachment mime type: text/x-python-script → text/plain
Attachment #445859 - Flags: review?(vish.mozilla) → review+
(Reporter)

Comment 6

8 years ago
Created attachment 446632 [details] [diff] [review]
Logout tc-05/20

Updated the formatting to match pep rules
Attachment #446632 - Flags: review?(vish.mozilla)
looks good. commit it.
Attachment #446632 - Flags: review?(vish.mozilla) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment #445859 - Attachment filename: verifyUserLogout.py → verifyUserLogout.py
Attachment #445859 - Flags: review?(trumanwsmith)
Attachment #445859 - Flags: review?(stephen.donner)
Attachment #445859 - Flags: review?(mozbugs.retornam)
You need to log in before you can comment on or make changes to this bug.