566550 - make nsAccUtils::TextLength unsigned

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[timeless]

Defined as a function prototype in:

    * content/base/public/nsIContent.h
          o line 499 -- virtual PRUint32 TextLength() = 0; 
    * content/base/src/nsGenericDOMDataNode.h
          o line 214 -- virtual PRUint32 TextLength(); 
    * content/base/src/nsGenericElement.h
          o line 410 -- virtual PRUint32 TextLength(); 
    * accessible/src/base/nsAccUtils.h
          o line 343 -- static PRInt32 TextLength(nsIAccessible *aAccessible);

Comment 1

[timeless]

the code pretends to use -1 as an error case, however it doesn't look like callers like nsHyperTextAccessible::GetPosAndText are particularly careful about handling that.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> the code pretends to use -1 as an error case, however it doesn't look like
> callers like nsHyperTextAccessible::GetPosAndText are particularly careful
> about handling that.

Looks so. I think it's ok if TextLength() should return 0 and assert when failure is happen.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

1) make TextLength() return unsigned int
2) make TextLength() to take nsAccessible*

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 446951 [details] [diff] [review]
patch

r=me. This looks nice, esp since it gets rid of some extra code.

Comment 5

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/1817cd496b3b