56659 - [MLK] Leaking nsPluginInstanceOwner (cycle with nsTimerImpl)

Status: VERIFIED DUPLICATE of bug 85231

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Patrick C. Beard]

We have a cycle of references between nsPluginInstanceOwner and nsTimerImpl 
objects. This is causing plugin instances to leak, which could have a large 
impact on memory. I don't know if this leak is XP, as there are lots of #ifdefs 
in nsObjectFrame.cpp, but this should be investigated soon.

Comment 1

[Patrick C. Beard]

Attachment: Leak report showing the cycle.

Comment 2

[ekrock's old account (dead)]

Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because
the Netscape engineer it is assigned to is overburdened.

Comment 3

[Peter Lubczynski]

Memory leaks should be fixed.

David Baron: can I get some help on fixing this on Mac?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is there any reason to think this is Mac only?  (FWIW, I can help with things
that are only on Linux, but not Mac...)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Just discussed this with bnesse (who suspects it of being the cause of some
other bug):  solution is probably to null |mTimer| in
nsPluginInstanceOwner::CancelTimer, which would fix the problem in every case
except if the frame tree leaks due to a leaked pres shell.

Comment 6

[Brian Nesse (gone)]

This bug is the root cause of bug 85231. Duping to that one because it has all
the right keywords. :)

*** This bug has been marked as a duplicate of 85231 ***

Comment 7

[rubydoo123]

marking verified