566665 - jstests.py -s should print command lines rather than lists of strings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

without this patch,

$ python tests/jstests.py -s  ./d-objdir/js
['/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js', '-f', 'shell.js', '-f', 'e4x/shell.js', '-f', 'e4x/decompilation/shell.js', '-f', './e4x/decompilation/regress-349814.js']
['/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js', '-f', 'shell.js', '-f', 'e4x/shell.js', '-f', 'e4x/decompilation/shell.js', '-f', './e4x/decompilation/decompile-xml-escapes.js']
['/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js', '-f', 'shell.js', '-f', 'e4x/shell.js', '-f', 'e4x/decompilation/shell.js', '-f', './e4x/decompilation/regress-349815.js']
...

With the patch, the output is friendlier to cut-and-paste:

/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js -f shell.js -f e4x/shell.js -f e4x/decompilation/shell.js -f ./e4x/decompilation/regress-349814.js
/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js -f shell.js -f e4x/shell.js -f e4x/decompilation/shell.js -f ./e4x/decompilation/decompile-xml-escapes.js
/home/jorendorff/dev/tracemonkey/js/src/d-objdir/js -f shell.js -f e4x/shell.js -f e4x/decompilation/shell.js -f ./e4x/decompilation/regress-349815.js
...

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

subprocess.list2cmdline is totally undocumented and its docstring is very explicit that it follows MS CRT rules for building the command line. But that's good enough for bash in all but crazy and unlikely cases.

Comment 2

[David Mandelin [:dmandelin]]

Comment on attachment 446007 [details] [diff] [review]
v1

Cool. I've wished this could be done for some time, but I didn't know it could be done properly so easily.

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/3fe3507be338

Comment 4

[Nicholas Nethercote [inactive]]

+1 jorendorff!

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/3fe3507be338