Web theme: -moz-border-radius causes unexpected rounded corners in forms

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
4 years ago

People

(Reporter: mbrubeck, Assigned: mfinkle)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Created attachment 446008 [details] [diff] [review]
patch: remove -moz-border-radius from content.css

Setting -moz-border-radius causes unexpected rounded corners on sites with styled form elements (e.g. bug 565964).  There is no obvious way for web authors to fix this.  (They would need to add "-moz-border-radius: 0" to their own stylesheets with exactly the right selectors.)

One solution is to remove the rounded borders from our web theme.  See the attached patch and screenshot.
Attachment #446008 - Flags: ui-review?(madhava)
Attachment #446008 - Flags: review?(mark.finkle)
(Reporter)

Comment 1

8 years ago
Created attachment 446009 [details]
screenshot with patch
I am leaning towards doing this so we don't cause web styling incompatibilities.
changing the border-radius to 3px seems to mitigate the styling issues while still giving the widgets a "nice" look
Comment on attachment 446008 [details] [diff] [review]
patch: remove -moz-border-radius from content.css

We decided to use a 3px radius as a compromise. Path coming up.
Attachment #446008 - Flags: ui-review?(madhava)
Attachment #446008 - Flags: review?(mark.finkle)
Attachment #446008 - Flags: review-
Created attachment 446027 [details] [diff] [review]
alt patch

3px border-radius
Assignee: mbrubeck → mark.finkle
Attachment #446008 - Attachment is obsolete: true
Attachment #446027 - Flags: review?(mbrubeck)
(Reporter)

Updated

8 years ago
Attachment #446027 - Flags: review?(mbrubeck) → review+
pushed to m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/07997ab9d32a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100519 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100519 Namoroka/3.7a5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.