566688 - WebGLBuffer bound to a target can be bound to another target in its lifetime

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Cedric Vivier [:cedricv]]

WebGL spec states at 5.14.5 :

"""
void bindBuffer(GLenum target, WebGLBuffer buffer)
Binds the given WebGLBuffer object to the given binding point (target), either ARRAY_BUFFER or ELEMENT_ARRAY_BUFFER. If the buffer is null then any buffer currently bound to this target is unbound. A given WebGLBuffer object may only be bound to one of the ARRAY_BUFFER or ELEMENT_ARRAY_BUFFER target in its lifetime. An attempt to bind a buffer object to the other target will generate an INVALID_OPERATION error, and the current binding will remain untouched.
"""

Currently the same buffer can be bound to both targets without error.

Comment 1

[Cedric Vivier [:cedricv]]

Attachment: Fix

Make all tests of buffer-bind-test.html PASS.

Comment 2

[Cedric Vivier [:cedricv]]

Comment on attachment 446033 [details] [diff] [review]
Fix

Ooops, okay this is crap... but the good thing is that it shows buffer-bind-tests should be greatly improved to check that the binding (or unbinding if null buffer) has been done correctly.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Benoit is working on fixing this in bug 567565.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

This has been fixed.