handle brackets in mxr searches to glimpse

VERIFIED FIXED

Status

Webtools
MXR
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: blassey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

I tried to search for 'input[type="file"]' and mxr seems to have choked on it.

Comment 1

8 years ago
thanks. it turns out that glimpse is at least a bit broken :(


[timeless@konigsberg mxr-test]$ /usr/local/bin/glimpse -i -H /data/mxr-data/mozilla-central -y -n -e 'input\[type="file"\]' 2>&1|head -5

/usr/local/bin/glimpse: unmatched '[', ']' (use \[, \] to search for [, ])
glimpse: error in searching index
Warning: pattern has words present in the stop-list: must SEARCH the files
/data/mxr-data/mozilla-central/mozilla-central/layout/style/contenteditable.css: 101: *|*:-moz-read-write > input[type="file"],
/data/mxr-data/mozilla-central/mozilla-central/layout/style/forms.css: 405: input[type="file"] {

So the "please file a bug links" came from those first 3 lines (which go to stderr)
Status: NEW → ASSIGNED
Summary: glimpse parse error → handle brackets in mxr searches to glimpse

Comment 2

8 years ago
http://hg.mozilla.org/webtools/mxr/rev/fe400cc13eee
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 3

8 years ago
http://mxr.mozilla.org/mozilla/search?string=input[type%3D%22file%22]&case=1&find=css%24&tree=mozilla seems to produce results.  (The URL in the URL field took too long and gave me not results, so I limited it to CSS files.)

(timeless asked me to go around and verify a few fixed mxr bugs.)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.