566712 - [z][sk] plural forms are not working

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Wil Clouser [:clouserw]]

wladow pointed out on IRC that the header on https://preview.addons.mozilla.org/sk/firefox/?browse=featured was showing the incorrect string "1 490 099 106 prevzatý doplnok"

I looked into it, and the sk file is using:

Plural-Forms: nplurals=3; plural=n==1 ? 0 : n>=2 && n<=4 ? 1 : 2

Which I'm pretty sure is incorrect.  Gettext recommends:

Plural-Forms: nplurals=3; \
   plural=n==1 ? 0 : \
      n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;


We were using something similar in 2007 until it got changed in r2701 to what it is today.  I'm filing this bug to get input from the sk team on what we should be using.

An aside, even with the bad plural-form string, I think we should be seeing prevzatých in the header, but I figured I'd solve one problem at a time.

Comment 1

[Vlado Valastiak [:wladow]]

Thanks for filing the bug, Wil. However I have to disagree with you, our pluralform used to work few weeks ago for sure. Moreover the czech team is using the same form as we are and they have no problem with it, pls check AMO cs.

I'll try to use gettext recommended form later today and will see if it helps.

Comment 2

[Vlado Valastiak [:wladow]]

Well, the recommended form is not working either. Besides I'm not sure where you got it, but looking closer at the form it is not suitable for SK. We've got:
1 -> form[0]
2-4 -> form[1]
0,5+ -> form[2]

The one you're recommending says:

1 -> form[0]
numbers ending with 2-4, but not 12-14 -> form[1]
0,12-14,numbers ending with 0,1,5-9 -> form[2]

This seems to be a pluralform for PL, I think.

So now I'm going with:
"Plural-Forms: nplurals=3; plural=(n==1) ? 0 : (n>=2 && n<=4) ? 1 : 2;\n"
and waiting for another l10n content push to see if this is what zamboni will accept.

FYI after a little more investigation it seems this is affecting only a zamboni sites:

https://addons.mozilla.org/sk/firefox/?browse=featured - does not work
https://addons.mozilla.org/sk/firefox/addon/7661/ - does not work
https://addons.mozilla.org/sk/firefox/personas/ - works fine
https://addons.mozilla.org/sk/firefox/collections/editors_picks - works fine

Could you pls confirm that those pages where our pluralform is not working are zamboni pages?

Comment 3

[Wil Clouser [:clouserw]]

Yes, those pages where it isn't working is zamboni.  I can also reproduce it on my dev copy.  I'll try it with your new form tomorrow.

Comment 4

[Wil Clouser [:clouserw]]

This is fixed with http://github.com/clouserw/tower/commit/bcccd22b7df5cd66277eed2387cb4e82f2854f21

Since that is a change to an external library, I don't know if preview will pick that up automatically.  We'll find out!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Seems fine to me on preview; Vlado, can you verify please?  Thanks!

Comment 6

[Vlado Valastiak [:wladow]]

Stephen, no, it still doesn't work on preview. See comment 4 for the possible reason.

Comment 7

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> This is fixed with
> http://github.com/clouserw/tower/commit/bcccd22b7df5cd66277eed2387cb4e82f2854f21
> 
> Since that is a change to an external library, I don't know if preview will
> pick that up automatically.  We'll find out!

I just pushed the update to zamboni-lib, it should be on preview in a few minutes.

Comment 8

[Vlado Valastiak [:wladow]]

Yep, this is fixed and verified. Thank you Wil and guys.