566772 - Remove the lib/pki1 directory from CVS

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

lib/pki1 seems to be an earlier attempt to implement PKIX:
http://mxr.mozilla.org/security/source/security/nss/lib/pki1/

None of the .c files are being compiled, none of the .h files are publicly
exported:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/pki1/manifest.mn&rev=1.10&mark=50-51,55#41

and the only thing we need from the .h files is the NSSOID typedef.
We don't even access any member of the NSSOID structure.

I propose that we remove all the files in lib/pki1 from CVS to avoid
confusion.  (My GSoC student Hanno wondered if he needed to add the
PKCS #1 RSA-OAEP and RSA-PSS OIDs to lib/pki1/oids.txt, which prompted
me to look into this.)

For ease of code review, the attached patch omits the CVS removal of the
files in lib/pki1.

Comment 1

[Robert Relyea]

Most of these are stan functions that probably should be part of nssbase.

I would prefer to make NSSOID opaque for now. I presume you need the concrete declaration to deal with the NSSOID *algorithms[]; declaration? I'd rather change those to NSSOID **algorithms. The functions are unimplemented and not exported.

bob

Comment 2

[Robert Relyea]

Comment on attachment 446120 [details] [diff] [review]
Proposed patch

r- based on my previous comments.

I'm OK with removing pki1. my only hardache is the concrete definition for NSSOIDStr.

bob

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch

Remove concrete definition of the NSSOIDStr structure.

Bob, you're right.  struct NSSOIDStr can be an opaque type.  In fact,
I added the intentionally broken definition of struct NSSOIDStr to
doublecheck that we aren't using the struct definition.

I removed the struct definition and added a comment to note that
struct NSSOIDStr is an unused opaque structure.

Comment 4

[Robert Relyea]

Comment on attachment 446584 [details] [diff] [review]
Proposed patch

r+ rrelyea

Comment 5

[Wan-Teh Chang]

I checked in the patch on the NSS trunk for NSS 3.12.7.

Checking in lib/manifest.mn;
/cvsroot/mozilla/security/nss/lib/manifest.mn,v  <--  manifest.mn
new revision: 1.23; previous revision: 1.22
done
Checking in lib/pki/cryptocontext.c;
/cvsroot/mozilla/security/nss/lib/pki/cryptocontext.c,v  <--  cryptocontext.c
new revision: 1.19; previous revision: 1.18
done
Checking in lib/pki/nsspki.h;
/cvsroot/mozilla/security/nss/lib/pki/nsspki.h,v  <--  nsspki.h
new revision: 1.13; previous revision: 1.12
done
Checking in lib/pki/nsspkit.h;
/cvsroot/mozilla/security/nss/lib/pki/nsspkit.h,v  <--  nsspkit.h
new revision: 1.8; previous revision: 1.7
done
Checking in lib/pki/trustdomain.c;
/cvsroot/mozilla/security/nss/lib/pki/trustdomain.c,v  <--  trustdomain.c
new revision: 1.62; previous revision: 1.61
done
Removing lib/pki1/Makefile;
/cvsroot/mozilla/security/nss/lib/pki1/Makefile,v  <--  Makefile
new revision: delete; previous revision: 1.10
done
Removing lib/pki1/atav.c;
/cvsroot/mozilla/security/nss/lib/pki1/atav.c,v  <--  atav.c
new revision: delete; previous revision: 1.8
done
Removing lib/pki1/config.mk;
/cvsroot/mozilla/security/nss/lib/pki1/config.mk,v  <--  config.mk
new revision: delete; previous revision: 1.5
done
Removing lib/pki1/genname.c;
/cvsroot/mozilla/security/nss/lib/pki1/genname.c,v  <--  genname.c
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/gnseq.c;
/cvsroot/mozilla/security/nss/lib/pki1/gnseq.c,v  <--  gnseq.c
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/manifest.mn;
/cvsroot/mozilla/security/nss/lib/pki1/manifest.mn,v  <--  manifest.mn
new revision: delete; previous revision: 1.10
done
Removing lib/pki1/name.c;
/cvsroot/mozilla/security/nss/lib/pki1/name.c,v  <--  name.c
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/nsspki1.h;
/cvsroot/mozilla/security/nss/lib/pki1/nsspki1.h,v  <--  nsspki1.h
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/nsspki1t.h;
/cvsroot/mozilla/security/nss/lib/pki1/nsspki1t.h,v  <--  nsspki1t.h
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/oid.c;
/cvsroot/mozilla/security/nss/lib/pki1/oid.c,v  <--  oid.c
new revision: delete; previous revision: 1.6
done
Removing lib/pki1/oiddata.c;
/cvsroot/mozilla/security/nss/lib/pki1/oiddata.c,v  <--  oiddata.c
new revision: delete; previous revision: 1.6
done
Removing lib/pki1/oiddata.h;
/cvsroot/mozilla/security/nss/lib/pki1/oiddata.h,v  <--  oiddata.h
new revision: delete; previous revision: 1.4
done
Removing lib/pki1/oidgen.perl;
/cvsroot/mozilla/security/nss/lib/pki1/oidgen.perl,v  <--  oidgen.perl
new revision: delete; previous revision: 1.6
done
Removing lib/pki1/oids.txt;
/cvsroot/mozilla/security/nss/lib/pki1/oids.txt,v  <--  oids.txt
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/pki1.h;
/cvsroot/mozilla/security/nss/lib/pki1/pki1.h,v  <--  pki1.h
new revision: delete; previous revision: 1.5
done
Removing lib/pki1/pki1t.h;
/cvsroot/mozilla/security/nss/lib/pki1/pki1t.h,v  <--  pki1t.h
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/rdn.c;
/cvsroot/mozilla/security/nss/lib/pki1/rdn.c,v  <--  rdn.c
new revision: delete; previous revision: 1.3
done
Removing lib/pki1/rdnseq.c;
/cvsroot/mozilla/security/nss/lib/pki1/rdnseq.c,v  <--  rdnseq.c
new revision: delete; previous revision: 1.3
done