[IPC] Make desktop flash plugin works on Fennec QT.

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 446203 [details] [diff] [review]
Lie to flash and make it works on Qt port in windowless mode 

To make desktop GTK flash plugin works with fennec-QT, we should make two things:
1) lie about XEmbed support (otherwise flash will fail in NPP_New)
2) lie about support for NPNVToolkit NPNVGtk2.

This patch will make qt fennec works with desktop flash plugin
when next fennec preferences enabled:
pref("plugin.disable", false);
pref("dom.ipc.plugins.enabled", true);
Attachment #446203 - Flags: review?(dougt)
(Assignee)

Comment 1

8 years ago
Created attachment 446208 [details] [diff] [review]
Make possible to compile Qt with GTK2 together...

With first patch we are fixing test plugin page, but youtube still does not work and crashes...

Here is the patch which allow us to compile QT with GTK2 when it is available, and call gtk_init in mozilla-Qt port...
That is fixing youtube flash working on Fennec-QT desktop.
Assignee: nobody → romaxa

Comment 2

8 years ago
I really do not like mixing gtk and Qt.  Is there a way to restrict these changes to nsObjectFrame and its makefile?
(Assignee)

Comment 3

8 years ago
Created attachment 446444 [details] [diff] [review]
Use PRLoadLibrary, and only for plugin child
Attachment #446208 - Attachment is obsolete: true
Attachment #446444 - Flags: review?(dougt)

Comment 4

8 years ago
Comment on attachment 446444 [details] [diff] [review]
Use PRLoadLibrary, and only for plugin child

Much better, but lets add some comments as to why exactly we are doing this and cite this bug number.


Lets name gtk_init to: s_gtk_init

also, gtklib should be sGtkLib

With that, r+
Attachment #446444 - Flags: review?(dougt) → review+
(Assignee)

Comment 5

8 years ago
Created attachment 446451 [details] [diff] [review]
Second patch gtk_init updated

Updated

8 years ago
Attachment #446203 - Flags: review?(dougt) → review+
(Assignee)

Comment 6

8 years ago
Pushed in
http://hg.mozilla.org/mozilla-central/rev/4a19951d5b9c
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.