566862 - [uk] change 'uk' to '@AB_CD@' in browser/firefox-l10n.js and mobile/android/mobile-l10n.js

Status: RESOLVED FIXED

(Mozilla Localizations :: uk / Ukrainian, defect)

Description

[Axel Hecht [:Pike]]

Right now, 'uk' is hard-coded in the firefox-l10n.js file.

That's not a practical problem, but we've just ran into an issue where locale codes change and then things get surprising.

Mind changing that back?

Comment 1

[Tim Babych]

Sure, will commit now. Can you share a bit of background on this?

Comment 2

[Axel Hecht [:Pike]]

The scottish gaelic version used the irish localization, which hard-codes ga-IE, and thus gd is running as the wrong locale.

There are some renames of locale codes ahead for locales like pa-IN, too, or more generally locales where we should use script tags in the locale code.

Nothing affecting Ukrainian, I guess. Not sure if anyone would base their localization on Ukrainian either, but it's better to have a good working template used all around.

Comment 3

[Artem Polivanchuk]

Is it still actual?

Comment 4

[Axel Hecht [:Pike]]

Yes, see http://mxr.mozilla.org/l10n-mozilla-aurora/source/uk/browser/firefox-l10n.js

Comment 5

[Artem Polivanchuk]

Thanks Axel!
As I understood, the string
pref("general.useragent.locale", "uk");
should be replaced with
pref("general.useragent.locale", "uk_UA");

If I'm wrong, please give me the right correction for this string.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Artem Polivanchuk from comment #5)
> pref("general.useragent.locale", "uk_UA");

No, it actually needs to be literally "@AB_CD@"

pref("general.useragent.locale", "@AB_CD@");

And this affects also mobile for Ukranian
http://mxr.mozilla.org/l10n-mozilla-aurora/source/uk/mobile/android/mobile-l10n.js

Comment 7

[Artem Polivanchuk]

Thank you, Francesco!
Just pushed changes: https://hg.mozilla.org/releases/l10n/mozilla-aurora/uk/rev/f1fe8dba0c99
Please, check if everything is correct.

Comment 8

[Francesco Lodolo [:flod]]

Looks good to me. 

BTW, is anyone still working on l10n-central for 'uk'? I tried to pull the changesets from mozilla-aurora and it merges clean but, if nobody is actually doing work there, it might make sense to push the merged state to aurora and keep l10n-central in sync from time to time.

Comment 9

[Artem Polivanchuk]

So, is it already fixed?

Comment 10

[Francesco Lodolo [:flod]]

l10n-central is not fixed yet, I think I'd need a clarification about it (e.g. if we can merge aurora into central and ignore the current content).

Comment 11

[Artem Polivanchuk]

Attachment: Merged to Central

Already in central.