566919 - Serve non-browser add-on files as Content-Disposition: attachment

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
Try installing the add-on https://preview.addons.mozilla.org/en-US/mobile/addon/53633/


All non-Firefox add-on files should be served as attachments (when they are accessed from Firefox)

Comment 1

[Fred Wenzel [:wenzel]]

This is a dupe of another recent bug, I think.

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> This is a dupe of another recent bug, I think.

It sounds close to bug 565143, but it's annoyingly different.

When you're in Fennec (or Thunderbird, eventually), we want to serve xpis directly.  When you're in Firefox looking at /mobile, we want to serve them as attachments for easy downloading.

Comment 3

[krupa raj[:krupa]]

This also includes accessing Thunderbird add-ons in Firefox

STR:
1.Go to https://preview.addons.mozilla.org/en-US/thunderbird/addon/10183/
2.Click on the "Download Now" button
3.Click on the download button in the pop-up message

observed behavior:
firefox intercepts and tries to install the add-on.

Comment 4

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/5e7ff0fc8a

Comment 5

[krupa raj[:krupa]]

"Near me" is a mobile add-on.On clicking the "Download Now" button,Firefox intercepts and tries to install it.

add-on detail page:https://preview.addons.mozilla.org/en-US/mobile/addon/53633/

To check the supported apps on this add-on:
https://preview.addons.mozilla.org/en-US/developers/versions/edit/97716

So bug reported in comment #0 is not fixed.Reopening..

Comment 6

[Jeff Balogh (:jbalogh)]

You filed a different bug for mobile.  It's a different problem.  We treat certain apps as browser apps and serve the files as .xpi.  For non-browser apps (that's you, THUNDERBIRD), we serve attachments.

Fixing the mobile vs. firefox vs. thunderbird-the-browser is a different issue. This bug fixes the regression from remora.

Comment 7

[krupa raj[:krupa]]

Thunderbird add-ons get served as Content-Disposition: attachment.verified

https://preview.addons.mozilla.org/en-US/thunderbird/addon/246/
https://preview.addons.mozilla.org/en-US/thunderbird/addon/71/

verified