Closed
Bug 566956
Opened 15 years ago
Closed 15 years ago
Python Selenium RC Review: advanced_search_checked_kb_and_forum
Categories
(Testing Graveyard :: WebQA, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tgavankar, Unassigned)
References
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
tgavankar
:
review+
|
Details | Diff | Splinter Review |
Test advanced_search_checked_kb_and_forum of bug 566952, for review.
|
Reporter | |
Updated•15 years ago
|
Attachment #446314 -
Flags: review?(vish.mozilla)
|
||
Comment 1•15 years ago
|
||
We used to use lot of try/catch in our tests but our developers suggested that we should not catch the exceptions. We should just let the test fail at the first exception thrown.
|
|
||
Comment 2•15 years ago
|
||
1. in this line:
self.failUnless(sel.is_text_present(""))
why are you searching for an empty string?
2. remove imports to time,re if you are not going to use them.
|
|
Reporter | |
Updated•15 years ago
|
Attachment #446314 -
Flags: review?(vish.mozilla) → review+
|
|
Reporter | |
Comment 3•15 years ago
|
||
Committed to SVN
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•