56706 - bcORB not thread safe

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect, P3)

Description

[Jon Smirl]

bcORB triggers the not thread safe assert. This is because any random thread in 
my system can cause a Java component to be loaded. It is very likely that bcORB 
will be unloaded from a different thread thus triggering the assert. 

NS_IMPL_THREADSAFE_ISUPPORTS1 will disable the assert once the code has been 
checked for thread safety.

**[c++]hasRetval: 0
--nsresult bcJavaMarshalToolkit::UnMarshal
--[java]org.mozilla.xpcom.Utilities.callMethodByIndex 1 4
--[java]callMethodByIndex args[0] = bcFOP
--[java] org.mozilla.xpcom.Utilities.callMethodByIndex method null
--[java] Utilities.callMethodByIndex method finishednull
--[c++] bcXPCOMProxy::Release 1
--[c++] bcXPCOMProxy::GetInterfaceInfo iid={82600420-8660-11d4-b7dd-00a0cc3e7072
}
--bcXPCOMProxy::CallMethod setDocumentHandler [7]
--[c++] bcXPCOMProxy::Release 0
###!!! ASSERTION: bcORB not thread-safe: 'owningThread == NS_CurrentThread()', f
ile d:\cvs\mozilla\xpcom\base\nsDebug.cpp, line 490
Press any key to continue

Comment 1

[Asa Dotzler [:asa]]

setting Jon Smirl's bugs to New

Comment 2

[Igor Kushnirskiy]

Attachment: fix for the bug

Comment 3

[Igor Kushnirskiy]

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32712
is a fix for the bug.

bcORB got renamed to bcORBComponent.
It was threadsafe so the fix is to change 
NS_IMPL_ISUPPORTS
to NS_IMPL_THREADSAFE_ISUPPORTS

the other problem that ORB.cpp is not threadsafe.
78288 is created

I am closing this bug as fixed