567101 - default TOPSRCDIR to pwd

Status: RESOLVED INVALID

(Firefox :: Sync, enhancement)

Description

[Michael Fladischer]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.9) Gecko/20100501 Iceweasel/3.5.9 (like Firefox/3.5.9)
Build Identifier: weave-1.3b5

There are three occurances of $(TOPSRCDIR) in crypto/Makefile which is never defined anywhere. Thus using a simple `make´ fails to build the .xpi.

Reproducible: Always

Steps to Reproduce:
1. Run `make` on the source.

Actual Results:  
% LC_ALL=C make
mkdir -p dist
mkdir -p dist/stage
mkdir -p dist/xpi
make -C crypto stage
make[1]: Entering directory `/home/users/x/Development/weave-trunk/crypto'
mkdir -p ../dist/stage/components
ln -vsf `pwd`/IWeaveCrypto.xpt ../dist/stage/components
`../dist/stage/components/IWeaveCrypto.xpt' -> `/home/users/x/Development/weave-trunk/crypto/IWeaveCrypto.xpt'
ln -vsf `pwd`/IWeaveCrypto.h  /crypto-obsolete/src
ln: creating symbolic link `/crypto-obsolete/src': No such file or directory
make[1]: *** [stage] Error 1
make[1]: Leaving directory `/home/users/x/Development/weave-trunk/crypto'
make: *** [crypto] Error 2

Expected Results:  
Build a .xpi file.

Comment 1

[Mike Connor [:mconnor]]

The readme covers this (set it as an environment variable) but we could make assumptions here.

Comment 2

[Allison Naaktgeboren :ally]

sync triage: this is for the old extension, so it doesn't apply anymore. 

Thank you for letting us know.